Update create iModel package to itwinui-react V3#155
Merged
DanishMehmood-bit merged 9 commits intoiTwin:mainfrom May 12, 2025
Bentley-Vivek:vp/Update-create-iModel-package
Merged
Update create iModel package to itwinui-react V3#155DanishMehmood-bit merged 9 commits intoiTwin:mainfrom Bentley-Vivek:vp/Update-create-iModel-package
DanishMehmood-bit merged 9 commits intoiTwin:mainfrom
Bentley-Vivek:vp/Update-create-iModel-package
Conversation
veekeys
reviewed
Apr 25, 2025
Member
veekeys
left a comment
veekeys
left a comment
There was a problem hiding this comment.
Have you tested if no UI was broken after update?
Contributor
Author
We have tested in storybook and it is working fine |
veekeys
reviewed
Apr 30, 2025
veekeys
reviewed
May 5, 2025
veekeys
approved these changes
May 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are bumping to major version because some smaller component like UploadImage is wrapped inside Themeprovider which adds an extra div. Consumer applications (IC Portal) using this smaller components might face UI breaks.